In window.xts, start and end values of NA will be treated the same as NULL #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xts aims to be consistent w/zoo when possible. So I was asking you to test whether your changes make |
|
I don't think it will work with zoo because zoo uses is.null(start) and is.null(end) when checking the arguments, and the scope of this pull request would only be for xts. I guess that would require a separate change to the zoo package. |
|
I have made the separate change to the development version of |
|
@harvey131 sorry it took so long to get this merged. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the pull request to support start/end arguments as NA.
#345
I was not sure what you meant by testing window.zoo as well.