Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more time of day subsetting information to the documentation #304

Closed
braverock opened this issue Jul 28, 2019 · 1 comment · Fixed by #328
Closed

add more time of day subsetting information to the documentation #304

braverock opened this issue Jul 28, 2019 · 1 comment · Fixed by #328
Milestone
0.12.1

Comments

@braverock
Copy link
Contributor

Description

Time of day subsetting ['T08:00/T15:00'] has been supported by xts since 2008.

There is one question in the xts FAQ which discusses time of day subsetting, but nothing in the function documentation.

Add this information to the [.xts documentation, and add [.xts to the seealso for xts documentation.

Additional subsetting information could probably be added as well to assist users trying to figure things out.
@joshuaulrich
Copy link
Owner

Great suggestion! We need to make sure to document the required format "THH:MM:SS/THH:MM:SS" with emphasis on the leading "T" and leading zero. We should also make sure that [.xts is linked to xts in the SeeAlso section.

It might also help to note what currently doesn't work. For example, subsetting by a single time ("THH:MM"), and open-ended intervals ("/THH:MM"). And discuss what happens when the start of the interval is a time greater than the end of the interval (i.e. the behavior described in this commit).

@joshuaulrich joshuaulrich added this to the 0.12-0 milestone Aug 4, 2019
claymoremarshall pushed a commit to claymoremarshall/xts that referenced this issue Feb 23, 2020
Add futher examples to documentation on time of day subsetting.
bc2b5a7 
Expand the examples in the documentation for subset.xts and tclass.

In subset.xts extend \{seealso to include .index as both help
pages relate to subsetting.

In tclass, provide examples for each kind of subsetting available.

Fixes Issue joshuaulrich#304
@claymoremarshall claymoremarshall mentioned this issue Feb 23, 2020
Merged
claymoremarshall pushed a commit to claymoremarshall/xts that referenced this issue Feb 23, 2020
Add futher examples to documentation on time of day subsetting.
751a144 
Expand the examples in the documentation for subset.xts.Rd andd
tclass.Rd

In subset.xts.Rd, extend \{seealso to include ?.index as both help
pages relate to subsetting.

In tclass.Rd, provide examples for each kind of subsetting available.

Fixes Issue joshuaulrich#304
claymoremarshall pushed a commit to claymoremarshall/xts that referenced this issue Feb 23, 2020
Add further examples to documentation on time of day subsetting.
a3533f9 
Expand the examples in the documentation for subset.xts.Rd andd
tclass.Rd

In subset.xts.Rd, extend \{seealso to include ?.index as both help
pages relate to subsetting.

In tclass.Rd, provide examples for each kind of subsetting available.

Fixes Issue joshuaulrich#304
claymoremarshall pushed a commit to claymoremarshall/xts that referenced this issue Feb 23, 2020
Add further examples to documentation on time of day subsetting.
9dafdd6 
Expand the examples in the documentation for subset.xts.Rd andd
tclass.Rd

In subset.xts.Rd, extend \{seealso to include ?.index as both help
pages relate to subsetting.

In tclass.Rd, provide examples for each kind of subsetting available.

Fixes Issue joshuaulrich#304
@joshuaulrich joshuaulrich modified the milestones: 0.12-0, 0.12-1 Jul 12, 2020
@joshuaulrich joshuaulrich linked a pull request Aug 8, 2020 that will close this issue
Add futher examples to documentation on time of day subsetting. #328
Merged
joshuaulrich pushed a commit that referenced this issue Sep 5, 2020
@joshuaulrich
Add further examples to documentation on time of day subsetting.
209151d 
Expand the examples in the documentation for subset.xts.Rd andd
tclass.Rd

In subset.xts.Rd, extend \{seealso to include ?.index as both help
pages relate to subsetting.

In tclass.Rd, provide examples for each kind of subsetting available.

Fixes Issue #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.1
Development

Successfully merging a pull request may close this issue.

Add futher examples to documentation on time of day subsetting. claymoremarshall/xts
2 participants
@joshuaulrich @braverock