Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified signature and implementation #344

Merged

Conversation

ethanbsmith
Copy link
Contributor

simplified function signature and implementation to better support subsequent maintenance
should not be breaking change as existing usage of data.type is handled by ...

closes #343

@ethanbsmith
Copy link
Contributor Author

just realized that the the whole section below can be further simplified to probably 1 line. Ill do some testing and add another commit

 h <- curl::new_handle()
    curl::handle_setheaders(h, Authorization = paste("Token", api.key))
    response <- curl::curl_fetch_memory(URL, h)
    response.data <- rawToChar(response$content)
    stock.data <- read.csv(text=response.data, as.is=TRUE, header=TRUE)

@joshuaulrich
Copy link
Owner

Close call... I was just about to merge! Let me know when you think this is ready.

further simplified call to read.csv
@ethanbsmith
Copy link
Contributor Author

should be gtg

@joshuaulrich joshuaulrich merged commit f133a69 into joshuaulrich:master Oct 16, 2021
@joshuaulrich
Copy link
Owner

Awesome, thanks!

@ethanbsmith ethanbsmith deleted the 343_remove_data_type_parameter branch March 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify getSymbols.tiingo
2 participants