Closes #9, mistaken test condition

[MichaelChirico]

is.character('unit') is trivially TRUE for all values of unit argument, i.e. this test was on the variable name, not the variable itself.

Very simple fix; more importantly, test added to be sure this type test is working as intended.

Bug fixed is #9.

The second commit tinkers with .gitignore.

• .Rproj files are very small but don't really add much (e.g.)
• Having the trailing slash / on the .RProj.user folder was confusing RStudio for some reason. It kept trying to edit the .gitignore to add .RProj.user to the end... really an upstream bug but it doesn't hurt to make this fix.

[joshuaulrich]

The test looks great. The only changes I would ask for are cosmetic/preferences.

1. Undo the whitespace changes to the doxygen comments in lines 51-54.
2. Remove the addition of *.Rproj to .gitignore from the fix commit (put it in a separate commit if you think it's a useful change).
3. Amend the commit message according to contributing guidelines (link is to xts, because I haven't added one to this repo; apologies).

I can make any/all of these changes, if you prefer. I only need access to push to this branch.

[MichaelChirico]

@joshuaulrich working now...

put it in a separate commit if you think it's a useful change

A separate commit is OK, or you a separate PR?

[joshuaulrich]

Separate commit in this PR is fine. Thanks!

[MichaelChirico]

@joshuaulrich should be ready to merge, I think. In any case I added you as a collaborator to my fork in case you want to tinker.

[joshuaulrich]

Merged, thanks!

[MichaelChirico]

my pleasure!

…

On Wed, Oct 24, 2018, 7:18 PM Joshua Ulrich ***@***.***> wrote: Merged, thanks! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQQddyvdueecPrKsZoUZ8ie3sSunfHRks5uoEyPgaJpZM4X1Rbz> .